ordered = TRUE for colorFactor fixes #800
#801
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When the code is written as `pal <- colorFactor(c("navy", "red"), domain = c("ship", "pirate"))`, then it is highly likely that the user's intention is to have `navy` for `ship`, and `red` for `pirate`.
Therefore it makes more sense that `colorFactor` should assume that the `domain` vector is already ordered (`ordered = TRUE`) unless stated otherwise.
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When the code is written as
pal <- colorFactor(c("navy", "red"), domain = c("ship", "pirate")), then it is highly likely that the user's intention is to havenavyforship, andredforpirate.Therefore it makes more sense that
colorFactorshould assume that thedomainvector is already ordered (ordered = TRUE) unless stated otherwise.PR task list:
ordered = TRUEmakes more sense forcolorFactor#800)Add tests (where appropriate)tests/testthat/R/zzz_viztest.Rdevtools::document()